Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for xfs filesystem #57

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Add support for xfs filesystem #57

merged 1 commit into from
Nov 29, 2019

Conversation

payes
Copy link
Contributor

@payes payes commented Nov 25, 2019 •
edited
Loading

This PR installs xfsprogs inside the container running csi plugin services.
fsType can be added to storage class parameters. Default fsType is ext4

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: cstor-csi-sc
provisioner: cstor.csi.openebs.io
allowVolumeExpansion: true
parameters:
  cas-type: cstor
  replicaCount: "1"
  cstorPoolCluster: cstor-sparse-cspc
  fsType: xfs

Signed-off-by: Payes [email protected]

utkarshmani1997
utkarshmani1997 approved these changes Nov 26, 2019
View reviewed changes
Copy link

@utkarshmani1997 utkarshmani1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

pawanpraka1
pawanpraka1 approved these changes Nov 27, 2019
View reviewed changes
Copy link

@pawanpraka1 pawanpraka1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Kubernetes csi provisioner natively supports fstype.

openebs/zfs-localpv#10

prateekpandey14
prateekpandey14 approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prateekpandey14 prateekpandey14 merged commit cc5d4a3 into openebs-archive:master Nov 29, 2019
@ranjithwingrider ranjithwingrider mentioned this pull request Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekpandey14 prateekpandey14 prateekpandey14 approved these changes

@pawanpraka1 pawanpraka1 pawanpraka1 approved these changes

@utkarshmani1997 utkarshmani1997 utkarshmani1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@payes @prateekpandey14 @pawanpraka1 @utkarshmani1997