Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go routine starvation): Eliminate difference in go compiler and go.mod version #169

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

Ab-hishek
Copy link

@Ab-hishek Ab-hishek commented Dec 27, 2021

What this PR does:
Suspecting issue(starvation in Go routine scheduling) is difference in Go compiler version & go.mod version, basically Go compiler version must be >= Go mod version. Therefore, this PR makes the go version same for both of them.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • PR messages has document related information
  • Labelled this PR & related issue with documentation tag
  • PR messages has breaking changes related information
  • PR messages has upgrade related information
  • Labelled this PR & related issue with requires-upgrade tag
  • Tests updated

@mittachaitu mittachaitu requested a review from payes December 27, 2021 07:45
Copy link

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mittachaitu mittachaitu merged commit ef081da into openebs-archive:develop Dec 28, 2021
Ab-hishek pushed a commit to Ab-hishek/cstor-csi that referenced this pull request Dec 28, 2021
…ion openebs-archive#169

This commit updates the Go compiler to match go.mod version
mittachaitu pushed a commit that referenced this pull request Dec 28, 2021
…ion #169 (#171)

This commit updates the Go compiler to match go.mod version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants