Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bdc): update bdc builder with adding tag #36

Merged
merged 1 commit into from
May 6, 2020

Conversation

kmova
Copy link
Contributor

@kmova kmova commented Apr 8, 2020

Ref: openebs-archive/maya#1648

A new label fixed selector (openebs.io/block-device-tag)
has been added to BDC to help with narrowing down the
block devices that can be claimed via the BDC.

This will allow users to tag block devices
and indicate which tagged devices can be used
by the BDC.

Signed-off-by: kmova [email protected]

Ref: openebs-archive/maya#1648

A new label fixed selector (openebs.io/block-device-tag)
has been added to BDC to help with narrowing down the
block devices that can be claimed via the BDC.

This will allow users to tag block devices
and indicate which tagged devices can be used
by the BDC.

Signed-off-by: kmova <[email protected]>
@kmova kmova requested review from akhilerm and sonasingh46 April 8, 2020 05:20
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
Lgtm

@sonasingh46 sonasingh46 merged commit 3f54063 into openebs-archive:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants