Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive HR Pose Estimation #479

Merged
merged 18 commits into from
Nov 23, 2023
Merged

Adaptive HR Pose Estimation #479

merged 18 commits into from
Nov 23, 2023

Conversation

mthodoris
Copy link
Collaborator

A new method is added for high resolution active perception. The new implementation is using an adaptive ROI selection in High-Resolution images

some offset variables that existed have been erased due to changes in the annotation file, and the sample image for evaluation
@tsampazk tsampazk added test sources Run style checks test tools Test the toolkit methods labels Nov 13, 2023
@passalis passalis changed the title Adaptive hr pose estimation Adaptive HR pose Estimation Nov 14, 2023
@passalis passalis changed the title Adaptive HR pose Estimation Adaptive HR Pose Estimation Nov 14, 2023
mthodoris and others added 6 commits November 15, 2023 13:38
Changed the image that used for inference and evaluation
typos

Learner:
removed unnecessary variables (e.g. offset value) due to new sample image and annotation
changed the path that _download function, gets the images from ftp
typos

Tests:
added the new evaluation and inference functions that perform the "adaptive ROI selection pose estimation"
optimization webcam_demo
Update docs file
@mthodoris mthodoris marked this pull request as ready for review November 21, 2023 11:10
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mthodoris for the new features! I have added several comments below, mostly some minor issues.

if --run-comparison is enabled then it shows the comparison between lightweight openpose, hr-pose estimation primary method and adaptive method
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, missing the choices argument in the revised webcam demo, otherwise it looks good to me thank you!

…e_estimation/demos/webcam_demo.py

Co-authored-by: Kostas Tsampazis <[email protected]>
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tsampazk tsampazk merged commit d8a7423 into develop Nov 23, 2023
47 checks passed
@tsampazk tsampazk deleted the adaptive-HR-pose-estimation branch November 23, 2023 14:57
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
* new functions added for adaptive high-resolution pose estimation.
some offset variables that existed have been erased due to changes in the annotation file, and the sample image for evaluation

* added extra arguments for adaptive pose estimation

* Demos:
Changed the image that used for inference and evaluation
typos

Learner:
removed unnecessary variables (e.g. offset value) due to new sample image and annotation
changed the path that _download function, gets the images from ftp
typos

Tests:
added the new evaluation and inference functions that perform the "adaptive ROI selection pose estimation"

* fix bugs

* Learner fix bugs
optimization webcam_demo

* Learner fix bugs
Update docs file

* Apply suggestions from code review

Co-authored-by: Kostas Tsampazis <[email protected]>

* Update docs file

* Apply suggestions from code review

Co-authored-by: Kostas Tsampazis <[email protected]>

* Update docstrings

* fixed webcam demo issues
edit learner

* pep8 fix

* webcam demo runs hr pose estimation
if --run-comparison is enabled then it shows the comparison between lightweight openpose, hr-pose estimation primary method and adaptive method

* Readme edit for webcam demo

* Update projects/python/perception/pose_estimation/high_resolution_pose_estimation/demos/webcam_demo.py

Co-authored-by: Kostas Tsampazis <[email protected]>

---------

Co-authored-by: Nikolaos Passalis <[email protected]>
Co-authored-by: Kostas Tsampazis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test sources Run style checks test tools Test the toolkit methods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants