-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive HR Pose Estimation #479
Conversation
some offset variables that existed have been erased due to changes in the annotation file, and the sample image for evaluation
Changed the image that used for inference and evaluation typos Learner: removed unnecessary variables (e.g. offset value) due to new sample image and annotation changed the path that _download function, gets the images from ftp typos Tests: added the new evaluation and inference functions that perform the "adaptive ROI selection pose estimation"
…o adaptive-HR-pose-estimation
optimization webcam_demo
Update docs file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mthodoris for the new features! I have added several comments below, mostly some minor issues.
src/opendr/perception/pose_estimation/hr_pose_estimation/high_resolution_learner.py
Show resolved
Hide resolved
...python/perception/pose_estimation/high_resolution_pose_estimation/demos/benchmarking_demo.py
Outdated
Show resolved
Hide resolved
projects/python/perception/pose_estimation/high_resolution_pose_estimation/demos/eval_demo.py
Outdated
Show resolved
Hide resolved
...ts/python/perception/pose_estimation/high_resolution_pose_estimation/demos/inference_demo.py
Outdated
Show resolved
Hide resolved
projects/python/perception/pose_estimation/high_resolution_pose_estimation/demos/webcam_demo.py
Show resolved
Hide resolved
Co-authored-by: Kostas Tsampazis <[email protected]>
Co-authored-by: Kostas Tsampazis <[email protected]>
edit learner
if --run-comparison is enabled then it shows the comparison between lightweight openpose, hr-pose estimation primary method and adaptive method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment, missing the choices argument in the revised webcam demo, otherwise it looks good to me thank you!
projects/python/perception/pose_estimation/high_resolution_pose_estimation/demos/webcam_demo.py
Outdated
Show resolved
Hide resolved
…e_estimation/demos/webcam_demo.py Co-authored-by: Kostas Tsampazis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* new functions added for adaptive high-resolution pose estimation. some offset variables that existed have been erased due to changes in the annotation file, and the sample image for evaluation * added extra arguments for adaptive pose estimation * Demos: Changed the image that used for inference and evaluation typos Learner: removed unnecessary variables (e.g. offset value) due to new sample image and annotation changed the path that _download function, gets the images from ftp typos Tests: added the new evaluation and inference functions that perform the "adaptive ROI selection pose estimation" * fix bugs * Learner fix bugs optimization webcam_demo * Learner fix bugs Update docs file * Apply suggestions from code review Co-authored-by: Kostas Tsampazis <[email protected]> * Update docs file * Apply suggestions from code review Co-authored-by: Kostas Tsampazis <[email protected]> * Update docstrings * fixed webcam demo issues edit learner * pep8 fix * webcam demo runs hr pose estimation if --run-comparison is enabled then it shows the comparison between lightweight openpose, hr-pose estimation primary method and adaptive method * Readme edit for webcam demo * Update projects/python/perception/pose_estimation/high_resolution_pose_estimation/demos/webcam_demo.py Co-authored-by: Kostas Tsampazis <[email protected]> --------- Co-authored-by: Nikolaos Passalis <[email protected]> Co-authored-by: Kostas Tsampazis <[email protected]>
A new method is added for high resolution active perception. The new implementation is using an adaptive ROI selection in High-Resolution images