Test-tools improvement #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stall.sh after ROS installation (presumably builds ROS workspaces?)
…eout workaround for downloading
tsampazk
requested review from
passalis,
omichel and
stefaniapedrazzi
as code owners
|
New workflow should be good to go for normal usage, from my end it seems to be stable. Toolkit gets installed once and saved to github cache and then loaded for each separate tool. If test tools had been run recently (within last week) and no changes have been made to dependencies, requirements or install.sh, the previous installation is loaded and installation is skipped altogether. If anything goes wrong during cache loading, e.g. timeout on download which is a github issue, toolkit is reinstalled and tests run normally. Github cache (Actions->cache on github top menu) doesn't seem to require any intervention in regular tests use cases and should be managed automatically. |
omichel
approved these changes
Sep 25, 2023
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* Applied latest change from tests_suite.yml * Add echo message for identification * Moved identification at the beginning * Removed identification * Attempting to split the installation * Split installation in another job * Added activation of environment in test tools * Trying out some caching * Trying out separate installation job with cache * Fix cache version in test tools and keep only engine test for debugging * Trying out caching venv * Trying out some additional tests * Re-enabled all tests for full run * Attempting to install libopenblas etc * Added more system dependencies and disabled most tests to lessen load * Attempting to install Cython again * Attempting different Cython installation * Attempting retinaface make * Re-enable all other tests for ful lrun * Attempting install dependency * Added missing repositories for ROS * Attempting to remedy the timeouts on cache restore * Attempting to update apt after adding keys * Attempting to run make libopendr as it seems to be used in regular install.sh after ROS installation (presumably builds ROS workspaces?) * Temporary fix to nms * Temporary fix for nms * Temp fix seq2seq nms * Remove non-existing options * Update test_seq2seq_nms.py * Attempting to install mobile manipulation before running * Attempting make mobile manip * Removed make libopendr * Attempting to run mobile manip stuff without if * Added some echos * Update tests_suite.yml * Update tests_suite.yml * Readded if for mobile manipulation * Removed if altogether * Readded accidentally removed cd * Changed up the if to include multi object search for installing ROS deps * Attempting make libopendr again * Added opendr device * Modified ifs for end to end planning and mobile manip * Determining whether egl and dependencies are installed * Attempting installation of libegl1 and some attempted fixes on mobile manip if * Added if f or libegl installation and attempting to source setup.bash for end-to-end-planning * Removed ifs between mobile manip and and end-to-end, also enabled all tests for full run * Added ffmpeg system install and hashing dependencies.inis for cache key * Removed cache restore key and added test with and without cache * Testing if cache-hit * Added missing cache step id * Added some echos, added regular installation on cache miss, added timeout workaround for downloading * Fix * Add dummy dependency to test cache behaviour * Dummy code change * Removed dummy code change * Removed dummy dependency * Added additional hash name for cache * Fix actions versions * Fixed cache restoring * Increased timeout mins 3->5 * Removed ffmpeg system dependency * Added apt update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to manipulate github actions to install the toolkit once and then use this single installation to run all the tool tests in parallel, instead of reinstalling the whole toolkit in each separate VM for every tool.
Update: caching the venv partially works speeding up the whole procedure. It seems that some system dependencies are missing, will investigate further.
Update: Progressing well, need to reinstall some system dependencies for each tool which is a really fast process. Many tools also require retinaface's make to run or else they get some Cython errors. End to end planning and multi object search still get some errors, presumably because of ROS dependencies etc, investigating further.
Update: Latest issues were solved, now new speech transcription tools are broken, attempting fixes.
Update: All tests pass successfully, now trying out various scenarios to see if caching behaves as expected for normal use.