Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug test failures on master branch #431

Merged
merged 45 commits into from
May 17, 2023
Merged

Debug test failures on master branch #431

merged 45 commits into from
May 17, 2023

Conversation

stefaniapedrazzi
Copy link
Collaborator

@stefaniapedrazzi stefaniapedrazzi commented May 2, 2023 •
edited
Loading

  • Disable mobile manipulation test
  • PyTorch version bump
  • Fixed ONNX and loading interface changes
  • Fixed torchvision arguments
  • Removed inplace operation from edgespeechnets
  • Wheel version downgrade due to bug in the recent version
  • Added missing dependencies
  • Updated DCN loading to be backward compatible
  • Update macos testing evironment from deprecated macos-10.15 to macos-11

@stefaniapedrazzi stefaniapedrazzi added the test packages Test pip wheel and docker image label May 2, 2023
@stefaniapedrazzi stefaniapedrazzi self-assigned this May 2, 2023
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review May 2, 2023 08:44
@stefaniapedrazzi stefaniapedrazzi added the test tools Test the toolkit methods label May 2, 2023
@stefaniapedrazzi
Copy link
Collaborator Author

It seems there are issues with the version of the installed pytorch.
But checking the logs, the expected version seems to be installed:

2023-05-02T08:45:22.1287225Z Collecting torch==1.9.0 (from opendr-toolkit-engine)
2023-05-02T08:45:22.1361857Z   Downloading torch-1.9.0-cp38-cp38-manylinux1_x86_64.whl (831.4 MB)

All the failing tests are reporting error related to it.
Here are some examples of the test errors:

  • RuntimeError: Legacy torch==2.0.0+cu117 detected, some modules may not work properly. torch>=1.4.0,<2.0.0 is required. You can use pip or conda to upgrade
  • AttributeError: module 'torch' has no attribute '_six'
  • TypeError: export() got an unexpected keyword argument 'enable_onnx_checker'

@passalis
Copy link
Collaborator

passalis commented May 2, 2023

This is very weird, especially given that this runs on CI without GPU (the specific torch version has been compiled against cu117, which shouldn't be installed in any case). I suspect that there is a recent update (either in our codebase or in a dependency) that brought this as a dependency. I will try to check asap.

@passalis passalis removed the test packages Test pip wheel and docker image label May 15, 2023
@passalis passalis removed the test tools Test the toolkit methods label May 15, 2023
@passalis passalis added the test tools Test the toolkit methods label May 15, 2023
@stefaniapedrazzi
Copy link
Collaborator Author

It seems the manipulation_test is still failing.
We can comment it for now, merge this PR, and then debug it in a separate PR so that at least we can restore the tests.

stefaniapedrazzi
stefaniapedrazzi commented May 16, 2023
View reviewed changes
Copy link
Collaborator Author

@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I cannot approve this PR because I created it.
But @passalis you should be able to approve it.

passalis
passalis previously approved these changes May 16, 2023
View reviewed changes
tsampazk
tsampazk previously approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stefaniapedrazzi stefaniapedrazzi dismissed stale reviews from tsampazk and passalis via ff55f4d May 17, 2023 06:49
@stefaniapedrazzi
Copy link
Collaborator Author

The test-sources (macos-10.15) test is hanging in all the branches (including the scheduled tests).
It seems that the macos-10.15 image has been deprecated one year ago and completely removed recently.

I tried to simply upgrade the version in this PR.
If it shouldn't work I would merge this PR as-is and fix it in a separate branch.

@stefaniapedrazzi stefaniapedrazzi removed the test tools Test the toolkit methods label May 17, 2023
@stefaniapedrazzi
Copy link
Collaborator Author

The test-sources is now passing both on ubuntu and macos-11.

@passalis could you please change the merge requirements and replace the test-sources (macos-10.15) with the new test-sources (macos-11)?

tsampazk
tsampazk previously approved these changes May 17, 2023
View reviewed changes
@stefaniapedrazzi
Copy link
Collaborator Author

@tsampazk oops, I change the test_suite_develop just after your approval

@passalis
Copy link
Collaborator

The test-sources is now passing both on ubuntu and macos-11.

@passalis could you please change the merge requirements and replace the test-sources (macos-10.15) with the new test-sources (macos-11)?

Done. Thanks!

@stefaniapedrazzi stefaniapedrazzi merged commit 6cfb5ce into master May 17, 2023
@stefaniapedrazzi stefaniapedrazzi deleted the debug-test-failure branch May 17, 2023 09:18
This was referenced Jun 5, 2023
Closed
Merged
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
@stefaniapedrazzi @passalis
Debug test failures on master branch (opendr-eu#431)
7177bb3 
* Disable mobile manipulation test

* PyTorch version bump

* PyTorch version bump

* PyTorch version bump

* PyTorch version bump

* PyTorch version bump

* Gym version bump

* Gym version bump

* Wheel version downgrade to openai/gym#3202

* Wheel version downgrade due to openai/gym#3202

* Wheel version downgrade due to openai/gym#3202

* Removed unsupported argument `enable_onnx_checker`

* Added opset version

* Added opset versions

* Fixed `load_state_dict_from_url` calls

* Fixed interpolation argument due to pytorchvision bump

* Fixed `load_state_dict_from_url` import

* Removed inplace operation

* Remove inplace operation

* Added missing dependency

* Style fix

* Removed unused import

* DCN update

* DCN update

* DCN update

* DCN version fix

* Fix DCN loading to be backward compatible

* Update tests_suite.yml

* Update tests_suite_develop.yml

* Update test_packages.yml

* Update test_packages.yml

* Update tests_suite.yml

* Update tests_suite_develop.yml

* Update test_packages.yml

* Update tests_suite.yml

* Update tests_suite_develop.yml

* Update test_packages.yml

* Update tests_suite.yml

* Update tests_suite_develop.yml

* Update deprecated macos image

* Disable source tests on ubuntu for testing

* Revert previous commit

* Try to fix apt errors

* Update macos image

---------

Co-authored-by: Nikolaos Passalis <[email protected]>
Co-authored-by: Nikolaos Passalis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsampazk tsampazk tsampazk approved these changes

@passalis passalis passalis approved these changes

@omichel omichel Awaiting requested review from omichel omichel is a code owner

Assignees

@stefaniapedrazzi stefaniapedrazzi

Labels
test sources Run style checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefaniapedrazzi @passalis @tsampazk