SiamRPN fixes and ab3dmot ros1 node duplicate shortcut #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsampazk
added
bug
tsampazk
requested review from
passalis,
omichel,
ad-daniel and
stefaniapedrazzi
as code owners
ad-daniel
previously approved these changes
Dec 14, 2022
tsampazk
changed the title
ad-daniel
previously approved these changes
Dec 14, 2022
|
I added another fix on this PR, for siamrpn ros1 node to include a built-in detector to initialize the tracker, so as not to open a different PR. Now the node initializes the tracker using an object detector. Out of the bboxes detected, the one closer to the input image center is chosen for initialization. We've discussed this with @vivinousi, and concluded that it is the easiest way to initialize the tracker and use the node out-of-the-box. I've already made this change in ROS2. |
tsampazk
changed the title
ad-daniel
approved these changes
Dec 19, 2022
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* Fix siamrpn script name in CMakeLists * Fix duplicate argparse shortcut tracking3d * SiamRPN node now uses built-in object detector * Minor comment fix Co-authored-by: ad-daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor fix for siamrpn node path.
It wasn't caught as by using
catkin_makethe scripts are not installed, i.e. only thedeveldirectory is created and needs to be sourced, so this didn't produce any issue.This is an thing that was brought up before, some nodes, but not all, are in the
CMakeLists.txtcatkin_install_python(PROGRAMS ... )for ROS1. As far as i can tell, these are used when you docatkin_make installand source theinstall/setup.bashto run the nodes.Edit: Integrated another minor fix that i missed earlier for object tracking 3d ab3dmot ROS1 node. The duplicate shortcut in argparse stopped the node from running entirely.