Continual ST-GCN #370
Merged
Continual ST-GCN #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHedegaard
requested review from
passalis,
omichel,
ad-daniel and
stefaniapedrazzi
as code owners
|
As we are still awaiting the upload of model weights from the OwnCloud folder to the FTP server, the tests in |
|
Ready for review @ad-daniel @passalis |
|
The failures are unrelated to this PR, seeing it across the board in the develop branch |
Good to know :-) |
ad-daniel
previously approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Thank you! I commited a likely fix for the rate limit error we have been getting lately, seems to have worked, more info here pytorch/vision#4156
tsampazk
requested changes
Dec 20, 2022
There was a problem hiding this comment.
Thank you @LukasHedegaard! I added some comments below.
I am not sure about having a requirements file in the demos, maybe we can add your benchmark library in the tools requirements? I can't remember any other demo adding a requirement locally, that doesn't run out of the box.
projects/python/perception/skeleton_based_action_recognition/REAMDE.md
Outdated
Show resolved
Hide resolved
src/opendr/perception/skeleton_based_action_recognition/continual_stgcn_learner.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/skeleton_based_action_recognition/continual_stgcn_learner.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/skeleton_based_action_recognition/continual_stgcn_learner.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/skeleton_based_action_recognition/continual_stgcn_learner.py
Outdated
Show resolved
Hide resolved
Merged
…ual_stgcn_learner.py Co-authored-by: Kostas Tsampazis <[email protected]>
…ual_stgcn_learner.py Co-authored-by: Kostas Tsampazis <[email protected]>
…EAMDE.md Co-authored-by: Kostas Tsampazis <[email protected]>
Co-authored-by: Kostas Tsampazis <[email protected]>
ad-daniel
approved these changes
Dec 21, 2022
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* Add prelim impl for Continual Skeleton methods * Add co-stgcn benchmark project * Fix warmup in benchmark-costgcn.py * Update continual_stgcn_learner and test * doc updated * Update dependencies * Format coa_gcn and co_str files * Update cost_gcn impl for co lib v.1.0.0 * Add ONNX optimisation and inference * Bump opset to support co-agcn and co-str * Update benchmarking script * Update CHANGELOG with CoSTGCN * Simplify load in cost-gcn test * Update download * Add demo * Update demo README to include info on costgcn demo * Minor * More * Fix typo * Add CoSTGCNLearner to doc index.md * Update docs/reference/skeleton-based-action-recognition.md Co-authored-by: ad-daniel <[email protected]> * Update docs/reference/skeleton-based-action-recognition.md Co-authored-by: ad-daniel <[email protected]> * Update docs/reference/skeleton-based-action-recognition.md Co-authored-by: ad-daniel <[email protected]> * Update docs/reference/skeleton-based-action-recognition.md Co-authored-by: ad-daniel <[email protected]> * Update docs/reference/skeleton-based-action-recognition.md Co-authored-by: ad-daniel <[email protected]> * Add missing param description in docstring * Add missing param descriptions in docs * Fix param description * Add default value to docs * Fix rate limit bug * Fix sources * Fix sources * Fix sources * Update src/opendr/perception/skeleton_based_action_recognition/continual_stgcn_learner.py Co-authored-by: Kostas Tsampazis <[email protected]> * Update src/opendr/perception/skeleton_based_action_recognition/continual_stgcn_learner.py Co-authored-by: Kostas Tsampazis <[email protected]> * Update projects/python/perception/skeleton_based_action_recognition/REAMDE.md Co-authored-by: Kostas Tsampazis <[email protected]> * Update docs/reference/index.md Co-authored-by: Kostas Tsampazis <[email protected]> * Fix skeleton data prep docs * Rename to README * Fix path name * Change download to print if verbose Co-authored-by: Negar <[email protected]> Co-authored-by: Kostas Tsampazis <[email protected]> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: ad-daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a suite of continual spatio-temporal graph convolutional networks, namely the optimized Co ST-GCN, Co A-GCN, and Co S-TR, which can operate efficiently during frame-by-frame inference