Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros1 fixes heart anomaly detection #330

Merged
merged 12 commits into from
Oct 13, 2022

Conversation

minhquoc0712
Copy link
Collaborator

Fixed:

  • Update device code selection.
  • Update argparse.
  • Update input and output topic name, and docstring accordingly.

Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates in this node, changes look good and the node seems to run smoothly. I have left two very minor comments, and after those it will be good to go!

Copy link
Collaborator

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a detail, thank you

Copy link
Collaborator

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ad-daniel ad-daniel merged commit ce121ef into develop Oct 13, 2022
@ad-daniel ad-daniel deleted the ros1-fixes-heart-anomaly-detection branch October 13, 2022 08:35
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
* Update device code selection

* Update arguments name and default value

* Update parameter selection in argparse

* Update docstring in callback

* Update output topic name and add option for output topic name

* Update projects/opendr_ws/src/perception/scripts/heart_anomaly_detection.py

Co-authored-by: Kostas Tsampazis <[email protected]>

* Update projects/opendr_ws/src/perception/scripts/heart_anomaly_detection.py

Co-authored-by: Kostas Tsampazis <[email protected]>

* Update projects/opendr_ws/src/perception/scripts/heart_anomaly_detection.py

Co-authored-by: Kostas Tsampazis <[email protected]>
Co-authored-by: ad-daniel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test sources Run style checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants