-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ros1 fixes heart anomaly detection #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates in this node, changes look good and the node seems to run smoothly. I have left two very minor comments, and after those it will be good to go!
projects/opendr_ws/src/perception/scripts/heart_anomaly_detection.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/heart_anomaly_detection.py
Outdated
Show resolved
Hide resolved
…ion.py Co-authored-by: Kostas Tsampazis <[email protected]>
…ion.py Co-authored-by: Kostas Tsampazis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a detail, thank you
projects/opendr_ws/src/perception/scripts/heart_anomaly_detection.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
* Update device code selection * Update arguments name and default value * Update parameter selection in argparse * Update docstring in callback * Update output topic name and add option for output topic name * Update projects/opendr_ws/src/perception/scripts/heart_anomaly_detection.py Co-authored-by: Kostas Tsampazis <[email protected]> * Update projects/opendr_ws/src/perception/scripts/heart_anomaly_detection.py Co-authored-by: Kostas Tsampazis <[email protected]> * Update projects/opendr_ws/src/perception/scripts/heart_anomaly_detection.py Co-authored-by: Kostas Tsampazis <[email protected]> Co-authored-by: ad-daniel <[email protected]>
Fixed: