Ros1 fixed rgbd hand gestures recognition #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhquoc0712
requested review from
passalis,
omichel,
ad-daniel and
stefaniapedrazzi
as code owners
23 tasks
tsampazk
requested changes
Oct 4, 2022
There was a problem hiding this comment.
Thanks @minhquoc0712 for the fixes on this node! I have added minor suggestions in the review to make it more consistent with other nodes.
Edit: Also note that i wasn't able to fully test the node as i don't have access to a depth camera
projects/opendr_ws/src/perception/scripts/rgbd_hand_gesture_recognition.py
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/rgbd_hand_gesture_recognition.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/rgbd_hand_gesture_recognition.py
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/rgbd_hand_gesture_recognition.py
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/rgbd_hand_gesture_recognition.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/rgbd_hand_gesture_recognition.py
Outdated
Show resolved
Hide resolved
…ithub.com/opendr-eu/opendr into ros1-fixed-rgbd-hand-gestures-recognition
…cognition.py Modify queue size to avoid delays Co-authored-by: Kostas Tsampazis <[email protected]>
|
Hey @minhquoc0712, when you think the PR is ready please re-request a review |
tsampazk
reviewed
Oct 10, 2022
projects/opendr_ws/src/perception/scripts/rgbd_hand_gesture_recognition.py
Outdated
Show resolved
Hide resolved
|
I left a comment for a minor issue in a docstring, apart from this the node is good to go from my side! Thank you very much! |
ad-daniel
added
the
test release
tsampazk
approved these changes
Oct 11, 2022
ad-daniel
removed
the
test release
ad-daniel
approved these changes
Oct 11, 2022
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* Add argument parser for device parameter and update device selection * Change rosnode argument name to be consistent with other nodes * Add argument parser and update default value of rgb and depth image inputs, update docstring * rgbd_hand_gesture_recognition.py * Update projects/opendr_ws/src/perception/scripts/rgbd_hand_gesture_recognition.py Modify queue size to avoid delays Co-authored-by: Kostas Tsampazis <[email protected]> * Change gesture topic parameter name * Add blank lines and use double-quotes for docstring * Fix wrong arguments name in docstring in preprocess method * Change argument name in callback method * Add an argument for output topic name * Update output topic * Fix docstring in preprocess method Co-authored-by: Kostas Tsampazis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: