Nms module

[charsyme]

Non-maximum Suppression for Person Detection

[charsyme]

1. Test tools still in progress
2. Dataset and DL-models need to be uploaded on FTP server

[ad-daniel]

Sorry I just noticed a few things appear to be missing:

• ROS interface
• Changelog entry

incomplete

[ad-daniel]

PS: you can ignore the test source failing on mac, appears to be false positive

[charsyme]

Sorry I just noticed a few things appear to be missing:

* ROS interface

* Changelog entry

I updated index.md. Regarding ROS, I have already made modifications to ObjectDetectionSSDNode, in order for the NMS Module to be called internally. I will add an extra node if it is needed. However, I believe the inference time of the overall pipeline (detector + NMS) would unnecessary increase, if NMS would be called through a separate ROS Node.

[ad-daniel]

I see, I think you're right, better that way.
PS: by changelog I meant this: https://github.com/opendr-eu/opendr/blob/develop/CHANGELOG.md, but yes that was missing as well 😄

[charsyme]

I see, I think you're right, better that way. PS: by changelog I meant this: https://github.com/opendr-eu/opendr/blob/develop/CHANGELOG.md, but yes that was missing as well smile

Done!! 👍

[ad-daniel]

Thank you!

[passalis]

Thank you! Seems very nice!

I have the following comments/questions:

• It might not be clear if the user should use run_nms or infer. Perhaps we should clarify this in the description of these two functions.
• We should also perhaps explain in the documentation how this tool can be used. As far as I understand it can be used either as a standalone tool that receives the bounding boxes or as a part of an object detector (if passed in the infer function).
• Is there any specific reason for supporting only SSD? In general, I was wondering if we should create a wrapper class that can receive both an object detector and a non-maximum suppression class and just add the last part of the pipeline. This would allow for using the implemented algorithms with no change for all the object detectors supported by OpenDR with minimal code changes. However, I am not really 100% sure if this is indeed feasible and if additional code changes are needed in the object detectors to make this work.

[charsyme]

@passalis I have updated the documentation in https://github.com/opendr-eu/opendr/blob/33107efbd478d3d11408198c31b3b4967caf6100/docs/reference/object-detection-2d-nms-seq2seq_nms.md. The first comment is addressed in the documentation of the run_nms and the infer methods.The last two comments/questions are addressed in the introduction. Let me know if the documentation is still not clear enough.

[passalis]

Thank you!

[ad-daniel]

Thank you