Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Return all open PRs instead of filtering by date" #5

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

bmalehorn
Copy link

@bmalehorn bmalehorn commented Dec 10, 2021

Context

Revert #4.
While this commit worked, it increased the number of requests we make by a lot:
image

I have a better way of solving this, by paginating based on push date. Revert this so we can fix it in the future.

Origin

Me

Summary of Changes

Test Plan

  • task test
  • cat ~/tmp/test.json | go run cmd/check/main.go -> looks reasonable, not returning all
{
  "source": {
    "repository": "opendoor-labs/code",
    "access_token": "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",
    "base_branch": "master",
    "status_filters": [
      {
        "context": "ci/circleci: js_unit_tests",
        "state": "success"
      }
    ]
  },
  "version": {
    "commit": "200a959cf5cc1cf1156a528a7269b5c66bc8493d",
    "committed": "2021-10-26T05:38:43Z",
    "pr": "36394"
  }
}
  • push docker image & run in admiral's pipeline

to deploy:

  • push as docker latest image

Documentation

N/A

@bmalehorn bmalehorn changed the title Bm/revert fix telia oss 26 Revert "Return all open PRs instead of filtering by date" Dec 10, 2021
@bmalehorn bmalehorn merged commit 9a56bb9 into master Dec 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the bm/revert-fix-telia-oss-26 branch December 10, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants