This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[PPL] Support index name with date suffix #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #983 +/- ##
=============================================
- Coverage 99.87% 99.87% -0.01%
- Complexity 2381 2383 +2
=============================================
Files 234 234
Lines 5477 5470 -7
Branches 357 357
=============================================
- Hits 5470 5463 -7
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
chloe-zh
approved these changes
Jan 12, 2021
dai-chen
added a commit
that referenced
this pull request
Jan 12, 2021
* Change grammar and UT * Add more UT and IT * Support wildcard in index name with dots * Update doc with wildcard case * Add assertion for IT * Disable nested field in PPL grammar * Remove commented out code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #980
Description of changes:
With the first change, the following index names are supported now. Please find more details in user manual doc below.
filebeat-2020.01.11filebeat-7.10-2020.01.11filebeat-2020.*orfilebeat-2020.*.11Documentation: Add a new paragraph for this support for index name only. https://github.com/dai-chen/sql/blob/support-index-name-with-dots-in-ppl/docs/experiment/ppl/general/identifiers.rst#description
Testing: All old UT/IT passed. Add new UT/IT to verify different index names.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.