Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Double quoted as string literal instead of identifier #974

Conversation

dai-chen
Copy link
Member

@dai-chen dai-chen commented Jan 7, 2021

Issue #, if available: #975

Description of changes: Change grammar, AST builder and documentation to make double quoted treated as a string literal rather than an identifier.

Documentation:

  1. https://github.com/dai-chen/sql/blob/use-double-quoted-as-string/docs/user/general/datatypes.rst#string-data-types
  2. https://github.com/dai-chen/sql/blob/use-double-quoted-as-string/docs/user/general/identifiers.rst#id1

Testing: UT and IT changed accordingly.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chen dai-chen added the SQL label Jan 7, 2021
@dai-chen dai-chen self-assigned this Jan 7, 2021
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #974 (8a4376e) into develop (9a08770) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #974   +/-   ##
==========================================
  Coverage      99.87%   99.87%           
  Complexity      2381     2381           
==========================================
  Files            234      234           
  Lines           5477     5477           
  Branches         357      357           
==========================================
  Hits            5470     5470           
  Misses             5        5           
  Partials           2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a08770...8a4376e. Read the comment docs.

@dai-chen dai-chen marked this pull request as ready for review January 7, 2021 22:38
Copy link
Contributor

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-chen dai-chen merged commit 6650a10 into opendistro-for-elasticsearch:develop Jan 12, 2021
@dai-chen dai-chen deleted the use-double-quoted-as-string branch January 12, 2021 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants