-
Notifications
You must be signed in to change notification settings - Fork 186
Enable sql function ifnull, nullif and isnull #962
Enable sql function ifnull, nullif and isnull #962
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #962 +/- ##
===========================================
Coverage 99.87% 99.87%
- Complexity 2347 2396 +49
===========================================
Files 232 234 +2
Lines 5395 5500 +105
Branches 350 357 +7
===========================================
+ Hits 5388 5493 +105
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
...zon/opendistroforelasticsearch/sql/expression/operator/predicate/UnaryPredicateOperator.java
Outdated
Show resolved
Hide resolved
...zon/opendistroforelasticsearch/sql/expression/operator/predicate/UnaryPredicateOperator.java
Outdated
Show resolved
Hide resolved
...opendistroforelasticsearch/sql/expression/operator/predicate/UnaryPredicateOperatorTest.java
Outdated
Show resolved
Hide resolved
...opendistroforelasticsearch/sql/expression/operator/predicate/UnaryPredicateOperatorTest.java
Outdated
Show resolved
Hide resolved
...g-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/FlowConrolFunctionIT.java
Outdated
Show resolved
Hide resolved
...g-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/FlowConrolFunctionIT.java
Outdated
Show resolved
Hide resolved
...g-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/FlowConrolFunctionIT.java
Outdated
Show resolved
Hide resolved
...g-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/FlowConrolFunctionIT.java
Outdated
Show resolved
Hide resolved
Could you also update the user manual and add corresponding doctest cases here: https://github.com/opendistro-for-elasticsearch/sql/blob/develop/docs/user/dql/functions.rst#conditional-functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integ-test/src/test/resources/correctness/queries/flowcontrol.txt
Outdated
Show resolved
Hide resolved
Btw, I missed An issue related: #861 |
...zon/opendistroforelasticsearch/sql/expression/operator/predicate/UnaryPredicateOperator.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/correctness/CorrectnessIT.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/FlowControlFunctionIT.java
Outdated
Show resolved
Hide resolved
.../java/com/amazon/opendistroforelasticsearch/sql/expression/function/BuiltinFunctionName.java
Show resolved
Hide resolved
...zon/opendistroforelasticsearch/sql/expression/operator/predicate/UnaryPredicateOperator.java
Show resolved
Hide resolved
...zon/opendistroforelasticsearch/sql/expression/operator/predicate/UnaryPredicateOperator.java
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just several minor comments. Thanks for your changes!
...zon/opendistroforelasticsearch/sql/expression/operator/predicate/UnaryPredicateOperator.java
Outdated
Show resolved
Hide resolved
...opendistroforelasticsearch/sql/expression/operator/predicate/UnaryPredicateOperatorTest.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/FlowControlFunctionIT.java
Outdated
Show resolved
Hide resolved
* rename Is_Null back to isNull
Issue #950 , if available:
Description of changes:
Add flow control functions ifNull, nullIf and isNull (#950)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.