This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support filter clause in aggregations #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sql/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/parser/context/QuerySpecificationTest.java
Codecov Report
@@ Coverage Diff @@
## develop #960 +/- ##
==========================================
Coverage 99.87% 99.87%
- Complexity 2347 2350 +3
==========================================
Files 232 232
Lines 5395 5413 +18
Branches 350 349 -1
==========================================
+ Hits 5388 5406 +18
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
penghuo
reviewed
Jan 6, 2021
...elasticsearch/sql/elasticsearch/storage/script/aggregation/dsl/MetricAggregationBuilder.java
Outdated
Show resolved
Hide resolved
penghuo
reviewed
Jan 6, 2021
...elasticsearch/sql/elasticsearch/storage/script/aggregation/dsl/MetricAggregationBuilder.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Jan 6, 2021
...ain/java/com/amazon/opendistroforelasticsearch/sql/expression/aggregation/AvgAggregator.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Jan 6, 2021
penghuo
approved these changes
Jan 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#964
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.