This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Use name and alias in JDBC format #932
Merged
dai-chen
merged 12 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:change-name-alias-in-jdbc-format
Dec 16, 2020
Merged
Use name and alias in JDBC format #932
dai-chen
merged 12 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:change-name-alias-in-jdbc-format
Dec 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #932 +/- ##
==========================================
Coverage 99.86% 99.86%
- Complexity 2334 2336 +2
==========================================
Files 232 232
Lines 5376 5379 +3
Branches 350 350
==========================================
+ Hits 5369 5372 +3
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
dai-chen
requested review from
chloe-zh,
penghuo,
zhongnansu and
harold-wang
December 15, 2020 22:39
zhongnansu
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chloe-zh
approved these changes
Dec 15, 2020
penghuo
pushed a commit
to penghuo/sql
that referenced
this pull request
Dec 17, 2020
* Rename getName to getNameOrAlias * Use original name as name in JDBC format * Support alias in CLI * Use local CLI for doctest * Add UT * Fix IT * Fix IT * Fix UT * Update javadoc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #939
Description of changes:
SQL:
NamedExpression
:getName
is renamed asgetNameOrAlias
. NowgetName
is just the getter forname
.ProjectOperator
always use original text (NamedExpression's name) asname
in QueryResult: JDBC formatter returns both name and alias in response for client side to use.QueryResult
uses name or alias as column name when iterated: Simple JSON formatter (PPL) and CSV formatter iterates QueryResult and uses it.SQL-CLI:
alias
as table header if present inschema
in response: sincealias
is used only when it's present, there should be no impact on PPL response.sql-cli
directly indoctest
module: in this way, no need to push sql-cli artifact to PyPi manually whenever changed.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.