This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support NULLS FIRST/LAST ordering for window functions #929
Merged
dai-chen
merged 8 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-null-first-last-for-window-function
Jan 5, 2021
Merged
Support NULLS FIRST/LAST ordering for window functions #929
dai-chen
merged 8 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-null-first-last-for-window-function
Jan 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #929 +/- ##
==========================================
Coverage 99.87% 99.87%
- Complexity 2341 2347 +6
==========================================
Files 232 232
Lines 5389 5395 +6
Branches 350 350
==========================================
+ Hits 5382 5388 +6
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
chloe-zh
approved these changes
Dec 14, 2020
penghuo
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #928
Description of changes: Previously window function only parses sorting order
ASC/DESC
. This PR is to support null orderingNULLS FIRST/LAST
for window functionOVER
clause too.The basic logic is same as
ORDER BY
clause handling:Testing: Because both H2 and SQLite has problem with null ordering in OVER clause, a new IT class is added manually.
Documentation: https://github.com/dai-chen/sql/blob/support-null-first-last-for-window-function/docs/user/dql/window.rst#row-number
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.