This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support cast function in SQL #926
Merged
penghuo
merged 7 commits into
opendistro-for-elasticsearch:develop
from
penghuo:support-cast
Dec 15, 2020
Merged
Support cast function in SQL #926
penghuo
merged 7 commits into
opendistro-for-elasticsearch:develop
from
penghuo:support-cast
Dec 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #926 +/- ##
===========================================
Coverage 99.86% 99.86%
- Complexity 2265 2321 +56
===========================================
Files 229 230 +1
Lines 5235 5342 +107
Branches 346 346
===========================================
+ Hits 5228 5335 +107
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
chloe-zh
approved these changes
Dec 14, 2020
dai-chen
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
dai-chen
reviewed
Dec 14, 2020
core/src/main/java/com/amazon/opendistroforelasticsearch/sql/ast/expression/Cast.java
Show resolved
Hide resolved
penghuo
added a commit
that referenced
this pull request
Dec 15, 2020
* init * update * update doc * update doc * update doc * fix breaking IT
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #915
Description of changes:
Todo: #924, #925
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.