Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Support cast function in SQL #926

Merged
merged 7 commits into from
Dec 15, 2020

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Dec 12, 2020

Issue #, if available: #915

Description of changes:

  1. Implement cast function in SQL.
  2. Update cast function doc. https://github.com/penghuo/sql/blob/support-cast/docs/user/dql/functions.rst#cast

Todo: #924, #925

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo requested review from dai-chen and chloe-zh December 12, 2020 00:22
@penghuo penghuo added the SQL label Dec 12, 2020
@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #926 (59a96dc) into develop (64c7bd6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop     #926    +/-   ##
===========================================
  Coverage      99.86%   99.86%            
- Complexity      2265     2321    +56     
===========================================
  Files            229      230     +1     
  Lines           5235     5342   +107     
  Branches         346      346            
===========================================
+ Hits            5228     5335   +107     
  Misses             5        5            
  Partials           2        2            
Impacted Files Coverage Δ Complexity Δ
...elasticsearch/sql/analysis/ExpressionAnalyzer.java 100.00% <100.00%> (ø) 31.00 <1.00> (+1.00)
...opendistroforelasticsearch/sql/expression/DSL.java 100.00% <100.00%> (ø) 128.00 <9.00> (+9.00)
...search/sql/expression/config/ExpressionConfig.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
.../expression/operator/convert/TypeCastOperator.java 100.00% <100.00%> (ø) 44.00 <44.00> (?)
...ticsearch/sql/sql/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø) 50.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c7bd6...59a96dc. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@penghuo penghuo merged commit 1675e2d into opendistro-for-elasticsearch:develop Dec 15, 2020
penghuo added a commit that referenced this pull request Dec 15, 2020
* init

* update

* update doc

* update doc

* update doc

* fix breaking IT
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants