Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix select all from subquery issue #902

Merged

Conversation

chloe-zh
Copy link
Member

@chloe-zh chloe-zh commented Dec 8, 2020

Issue #, if available:
#901

Description of changes:

  • Fixed select all fields issue in subquery analysis
  • Added unit test to build ast and IT in comparison test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chloe-zh chloe-zh self-assigned this Dec 8, 2020
@chloe-zh chloe-zh added bug Something isn't working SQL labels Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #902 (4f1d0b4) into develop (0cb3240) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #902   +/-   ##
==========================================
  Coverage      99.85%   99.85%           
- Complexity      2148     2153    +5     
==========================================
  Files            216      216           
  Lines           4850     4855    +5     
  Branches         320      323    +3     
==========================================
+ Hits            4843     4848    +5     
  Misses             5        5           
  Partials           2        2           
Impacted Files Coverage Δ Complexity Δ
...ndistroforelasticsearch/sql/analysis/Analyzer.java 100.00% <ø> (ø) 43.00 <0.00> (ø)
...arch/data/value/ElasticsearchExprValueFactory.java 100.00% <0.00%> (ø) 60.00% <0.00%> (+5.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb3240...4f1d0b4. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@chloe-zh chloe-zh merged commit e5dfd17 into opendistro-for-elasticsearch:develop Dec 9, 2020
joshuali925 pushed a commit that referenced this pull request Dec 9, 2020
* fix select all from subquery issue

* added a test case in comparison test
penghuo pushed a commit that referenced this pull request Dec 15, 2020
* fix select all from subquery issue

* added a test case in comparison test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants