This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix for ExprValueFactory construct issue #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #898 +/- ##
==========================================
Coverage 99.85% 99.85%
- Complexity 2148 2153 +5
==========================================
Files 216 216
Lines 4845 4856 +11
Branches 318 323 +5
==========================================
+ Hits 4838 4849 +11
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
|
Is #867 same issue? |
Thanks for noticing, it's the same issue. I will add a test for that case as well. |
chloe-zh
approved these changes
Dec 8, 2020
penghuo
reviewed
Dec 8, 2020
...n/opendistroforelasticsearch/sql/elasticsearch/data/value/ElasticsearchExprValueFactory.java
Show resolved
Hide resolved
joshuali925
pushed a commit
that referenced
this pull request
Dec 9, 2020
* add date & time * add datetime * try comparison test * add manual IT * add integration test for issue #867 Co-authored-by: Rupal Mahajan <>
penghuo
pushed a commit
that referenced
this pull request
Dec 15, 2020
* add date & time * add datetime * try comparison test * add manual IT * add integration test for issue #867 Co-authored-by: Rupal Mahajan <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #858, #867
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.