Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Added keywords option as alias identifier in SQL parser #866

Merged

Conversation

chloe-zh
Copy link
Member

Issue #, if available:

Description of changes:

  • Added keywords option as alias in SQL parser
  • Added tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chloe-zh chloe-zh added the SQL label Nov 30, 2020
@chloe-zh chloe-zh requested review from penghuo and dai-chen November 30, 2020 20:50
@chloe-zh chloe-zh self-assigned this Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #866 (70ce29e) into develop (0cb3240) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #866      +/-   ##
=============================================
- Coverage      99.85%   99.85%   -0.01%     
+ Complexity      2148     2144       -4     
=============================================
  Files            216      216              
  Lines           4850     4846       -4     
  Branches         320      320              
=============================================
- Hits            4843     4839       -4     
  Misses             5        5              
  Partials           2        2              
Impacted Files Coverage Δ Complexity Δ
...ticsearch/sql/ppl/parser/AstExpressionBuilder.java 100.00% <ø> (ø) 26.00 <0.00> (-2.00)
...ticsearch/sql/sql/parser/AstExpressionBuilder.java 100.00% <ø> (ø) 43.00 <0.00> (-1.00)
...csearch/sql/sql/parser/AstHavingFilterBuilder.java 100.00% <100.00%> (ø) 3.00 <1.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb3240...70ce29e. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add FIRST and LAST to keywordsCanBeId too? Thanks for the changes!

# Conflicts:
#	integ-test/src/test/resources/correctness/queries/select.txt
@chloe-zh chloe-zh requested a review from harold-wang December 8, 2020 22:03
@chloe-zh chloe-zh merged commit 0823e2d into opendistro-for-elasticsearch:develop Dec 9, 2020
penghuo pushed a commit that referenced this pull request Dec 15, 2020
* added keywords option in alias

* update

* update

* address comments

* added first and last in keywords
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants