This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Added keywords option as alias identifier in SQL parser #866
Merged
chloe-zh
merged 7 commits into
opendistro-for-elasticsearch:develop
from
chloe-zh:keyword-identifier
Dec 9, 2020
Merged
Added keywords option as alias identifier in SQL parser #866
chloe-zh
merged 7 commits into
opendistro-for-elasticsearch:develop
from
chloe-zh:keyword-identifier
Dec 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #866 +/- ##
=============================================
- Coverage 99.85% 99.85% -0.01%
+ Complexity 2148 2144 -4
=============================================
Files 216 216
Lines 4850 4846 -4
Branches 320 320
=============================================
- Hits 4843 4839 -4
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
dai-chen
reviewed
Dec 3, 2020
dai-chen
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add FIRST and LAST to keywordsCanBeId
too? Thanks for the changes!
# Conflicts: # integ-test/src/test/resources/correctness/queries/select.txt
penghuo
approved these changes
Dec 9, 2020
penghuo
pushed a commit
that referenced
this pull request
Dec 15, 2020
* added keywords option in alias * update * update * address comments * added first and last in keywords
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.