Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix ExprCollectionValue serialization bug #859

Merged

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Nov 26, 2020

Issue #, if available: N/A

Description of changes:

  1. Fix ExprCollectionValue serialization bug.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo requested review from dai-chen and chloe-zh November 26, 2020 00:33
Copy link
Member

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #859 (4185f62) into develop (200a76d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #859   +/-   ##
==========================================
  Coverage      99.85%   99.85%           
- Complexity      2115     2116    +1     
==========================================
  Files            214      214           
  Lines           4738     4742    +4     
  Branches         308      309    +1     
==========================================
+ Hits            4731     4735    +4     
  Misses             5        5           
  Partials           2        2           
Impacted Files Coverage Δ Complexity Δ
...sticsearch/sql/data/model/ExprCollectionValue.java 100.00% <100.00%> (ø) 14.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200a76d...4185f62. Read the comment docs.

@penghuo penghuo changed the title Fix expr array value json Fix ExprCollectionValue serialization bug Nov 26, 2020
@penghuo penghuo merged commit 2773bc3 into opendistro-for-elasticsearch:develop Nov 26, 2020
penghuo added a commit that referenced this pull request Dec 15, 2020
* fix expr array value json

* update
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants