Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix issue: sort order keyword is case sensitive #853

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

chloe-zh
Copy link
Member

Issue #, if available:
#852

Description of changes:

  • Replaced the sort order keyword to upper case when collecting the query information in QuerySpecification
  • Added tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chloe-zh chloe-zh requested review from penghuo and dai-chen November 24, 2020 20:30
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #853 (8834af5) into develop (42d79c2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #853   +/-   ##
==========================================
  Coverage      99.85%   99.85%           
  Complexity      2115     2115           
==========================================
  Files            214      214           
  Lines           4729     4729           
  Branches         308      308           
==========================================
  Hits            4722     4722           
  Misses             5        5           
  Partials           2        2           
Impacted Files Coverage Δ Complexity Δ
...rch/sql/sql/parser/context/QuerySpecification.java 100.00% <100.00%> (ø) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d79c2...8834af5. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@chloe-zh chloe-zh merged commit 755e3b7 into opendistro-for-elasticsearch:develop Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants