This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Sort field push down #848
Merged
penghuo
merged 7 commits into
opendistro-for-elasticsearch:develop
from
penghuo:sort-field-push-down
Nov 24, 2020
Merged
Sort field push down #848
penghuo
merged 7 commits into
opendistro-for-elasticsearch:develop
from
penghuo:sort-field-push-down
Nov 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #848 +/- ##
==========================================
Coverage 99.85% 99.85%
- Complexity 2102 2115 +13
==========================================
Files 209 214 +5
Lines 4678 4729 +51
Branches 308 308
==========================================
+ Hits 4671 4722 +51
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
dai-chen
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
chloe-zh
approved these changes
Nov 24, 2020
penghuo
added a commit
that referenced
this pull request
Dec 15, 2020
* init * remove the count option from sort * add filter push down rule * fix compile issue * add integ-test * update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New added features.
e.g. Filter - Sort - AnyChild will be optimized as Sort - Filter - AnyChild
e.g. Sort - Relation will be optimized as IndexScan(sort)
Limitation
Currently, the storage engine layer optimzation depend on the Elasticsearch DSL to push down to sort expression. But there are some limitations of Elasticsearch DSL.
Thus, currently, the Sort Operator will push down to Elasticsearch query only when the sort by list include fields only. if the Sort operator include sort expression, the optimization will do nothing, it will still fall back to default memory based implementation.
e.g. source=index | sort abs(a)
the expressionabs(a)
can't be push down to Elasticsearch DSL.Changes
Todo
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.