-
Notifications
You must be signed in to change notification settings - Fork 186
Migrate Query Workbench to 7.10 #840
Migrate Query Workbench to 7.10 #840
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #840 +/- ##
==========================================
Coverage ? 99.84%
Complexity ? 2093
==========================================
Files ? 209
Lines ? 4654
Branches ? 300
==========================================
Hits ? 4647
Misses ? 5
Partials ? 2 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github action failed, could you update node version?
Also artifact file name changed in 7.10, needs to rename it in github actions. You can use reporting as a reference https://github.com/opendistro-for-elasticsearch/kibana-reports/blob/dev/.github/workflows/kibana-reports-test-and-build-workflow.yml#L49
|
…into 7.10-migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Issue #, if available:
N/A
Description of changes:
Migrate query workbench to 7.10. Tested by running both
SQL
andPPL
queries and testing features such asExplain
,Download
, and sorting on columns.Related PR to update workflows: #844
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.