Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Migrate Query Workbench to 7.10 #840

Merged

Conversation

davidcui1225
Copy link
Contributor

@davidcui1225 davidcui1225 commented Nov 20, 2020

Issue #, if available:
N/A
Description of changes:
Migrate query workbench to 7.10. Tested by running both SQL and PPL queries and testing features such as Explain, Download, and sorting on columns.

Related PR to update workflows: #844

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@2be1590). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #840   +/-   ##
==========================================
  Coverage           ?   99.84%           
  Complexity         ?     2093           
==========================================
  Files              ?      209           
  Lines              ?     4654           
  Branches           ?      300           
==========================================
  Hits               ?     4647           
  Misses             ?        5           
  Partials           ?        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be1590...b3c381c. Read the comment docs.

Copy link
Contributor

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github action failed, could you update node version?
Also artifact file name changed in 7.10, needs to rename it in github actions. You can use reporting as a reference https://github.com/opendistro-for-elasticsearch/kibana-reports/blob/dev/.github/workflows/kibana-reports-test-and-build-workflow.yml#L49

workbench/kibana.json Outdated Show resolved Hide resolved
@chloe-zh
Copy link
Member

error [email protected]: The engine "node" is incompatible with this module. Expected version "10.22.1". Got "10.22.0"
Looks like the node version does not match in the workbench workflows, could you also change the node version in .github/workflows/sql-test-and-build-workflow.yml and .github/workflows/sql-workbench-release-workflow.yml?

Copy link
Member

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

Copy link
Contributor

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@davidcui1225 davidcui1225 merged commit bfa68b1 into opendistro-for-elasticsearch:develop Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants