Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

SQL release for Elasticsearch 7.10 #834

Merged

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Nov 18, 2020

Major breaking change

  1. The runner is in RestIntegTestTask has been moved to RestTestBasePlugin. The new introduced RestTestBasePlugin will apply the testClusters defined in TestClustersPlugin to all the Task inherit RestIntegTestTask. Thus, we defined the testClusters
  2. Remove integTest task from PluginBuildPlugin.

Description of changes

  1. Define the testClusters which will be used as runner for all the test tasks.
testClusters.all {	
    testDistribution = 'oss'
    plugin ":plugin"
}

2.Originally, the docTest use testClusters.integTest to run doc test. We define the new testCluster.docTestCluster for docTest and inherent the RunTask.

testClusters {
    docTestCluster {
        plugin ':plugin'
        testDistribution = 'oss'
    }
}
tasks.register("runRestTestCluster", RunTask) {
    description = 'Runs elasticsearch ODFE SQL plugin'
    useCluster testClusters.docTestCluster;
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo self-assigned this Nov 18, 2020
@penghuo penghuo requested review from dai-chen and chloe-zh November 18, 2020 17:01
Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes!

@penghuo penghuo merged commit 50ce34f into opendistro-for-elasticsearch:develop Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants