This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support SELECT DISTINCT in new SQL engine #833
Merged
dai-chen
merged 14 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-distinct-in-new-engine
Dec 8, 2020
Merged
Support SELECT DISTINCT in new SQL engine #833
dai-chen
merged 14 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-distinct-in-new-engine
Dec 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dai-chen
changed the title
Support distinct in new engine
Support SELECT DISTINCT in new SQL engine
Nov 17, 2020
Codecov Report
@@ Coverage Diff @@
## develop #833 +/- ##
==========================================
Coverage 99.85% 99.85%
Complexity 2148 2148
==========================================
Files 216 216
Lines 4845 4850 +5
Branches 318 320 +2
==========================================
+ Hits 4838 4843 +5
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
chloe-zh
approved these changes
Nov 27, 2020
penghuo
approved these changes
Dec 7, 2020
joshuali925
pushed a commit
that referenced
this pull request
Dec 9, 2020
* Change grammar * Add UT and AST builder * Pass jacoco * Pass jacoco * Add comparison test * Add doctest * Change doc * Prepare PR * Add doc for distinct * limitation
penghuo
pushed a commit
that referenced
this pull request
Dec 15, 2020
* Change grammar * Add UT and AST builder * Pass jacoco * Pass jacoco * Add comparison test * Add doctest * Change doc * Prepare PR * Add doc for distinct * limitation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #582
Description of changes: Change SQL grammar and build AST for
DISTINCT
keyword. Currently distinct is treated as an equivalent and special form ofGROUP BY
clause. So there is no change required in core engine.TODOs:
DISTINCT *
in Elasticsearch (add note in doc)COUNT(DISTINCT field)
.CASE
statement has problem with pushdown optimization.Documentation: Add distinct * limitation and new support for distinct expression in https://github.com/dai-chen/sql/blob/support-distinct-in-new-engine/docs/user/dql/basics.rst#example-4-selecting-distinct-fields
Testing: Add UT and comparison test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.