This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support subquery in FROM clause in new engine #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dai-chen
reviewed
Nov 13, 2020
core/src/main/java/com/amazon/opendistroforelasticsearch/sql/ast/tree/RelationSubquery.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amazon/opendistroforelasticsearch/sql/analysis/Analyzer.java
Show resolved
Hide resolved
...in/java/com/amazon/opendistroforelasticsearch/sql/sql/parser/context/QuerySpecification.java
Outdated
Show resolved
Hide resolved
|
Can you add examples for new features that we can support now? https://github.com/opendistro-for-elasticsearch/sql/blob/develop/docs/user/dql/complex.rst#example-2-subquery-in-from-clause For example, two levels of subquery in FROM, a subquery with GROUP BY etc. |
dai-chen
approved these changes
Nov 14, 2020
penghuo
approved these changes
Nov 16, 2020
Thanks, done! |
penghuo
pushed a commit
that referenced
this pull request
Dec 15, 2020
* support subquery in from * update * added java doc * added unit test * added comparison test cases * skipped a broken test in SubqueryIT.java due to different schema in new engine * added case for issue #375 * update * update * address comments * address comments * put the context push after subquery analysis recursion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#375
Description of changes:
RelationSubqueryin AST standing for subquery as tableSubqueryIT.javacaused by different schema in new engineBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.