This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support COUNT star and literal in new engine #802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Support
COUNT(*)
andCOUNT(1)
in the new SQL engine.*
to unresolvedAllFields
and then resolved literal"*"
. This is becauseCOUNT(*)
has same semantic asCOUNT(any literal)
. So there is no need to add a new expression class (SELECT *
has its own logic and don't need resolved AllFields expression neither)_index
forCOUNT(*)
andCOUNT(1)
.Example:
Documentation: https://github.com/dai-chen/sql/blob/support-count-star-and-literal/docs/user/dql/aggregations.rst#count-aggregations
Testing:
PrettyFormatResponseIT.aggregationFunctionInSelectCaseCheck()
. Please see the reason on@Ignore
message.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.