This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support ORDER BY in new SQL engine #782
Merged
dai-chen
merged 15 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-order-by-in-new-sql-engine
Oct 20, 2020
Merged
Support ORDER BY in new SQL engine #782
dai-chen
merged 15 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-order-by-in-new-sql-engine
Oct 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
reviewed
Oct 20, 2020
...in/java/com/amazon/opendistroforelasticsearch/sql/sql/parser/context/QuerySpecification.java
Outdated
Show resolved
Hide resolved
penghuo
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change.
chloe-zh
approved these changes
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
QualifiedName
toUnresolvedExpression
inField
so we can support order by any expression for SQL.AstSortBuilder
that sharesreplaceIfAliasOrOrdinal()
logic withAstAggregationBuilder
.ORDER BY
queries.With these changes, we can support ORDER BY field, scalar function, aggregate function, alias and ordinal. Please see the documentation below for more details.
Documentation: https://github.com/dai-chen/sql/blob/support-order-by-in-new-sql-engine/docs/user/dql/basics.rst#example-3-ordering-by-aggregate-functions
Testing:
OrderIT
anddateFunctionNameCaseInsensitiveTest()
: the former tests explain output and the latter testsDATE_FORMAT
which has different signature in legacy and new engine.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.