This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add support of basic data types byte, short, binary and add data type testing #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
reviewed
Oct 14, 2020
integ-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/ppl/DataTypeIT.java
Show resolved
Hide resolved
penghuo
reviewed
Oct 14, 2020
...on/opendistroforelasticsearch/sql/elasticsearch/data/value/ElasticsearchExprBinaryValue.java
Show resolved
Hide resolved
penghuo
reviewed
Oct 14, 2020
core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprByteValue.java
Outdated
Show resolved
Hide resolved
penghuo
reviewed
Oct 14, 2020
There was a problem hiding this comment.
could you also change the doc. https://github.com/opendistro-for-elasticsearch/sql/blob/develop/docs/user/general/datatypes.rst
anirudha
approved these changes
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
*Description of changes:
BYTE,SHORT(short type was already partly implemented before this PR), and es typeBINARYBYTEandSHORTin arithmetic operations and some mathematical functionsBINARYtype in JDBC driverRef: https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-data-types.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.