This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix cast statement in aggregate function return 0 #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #772
Description of changes: As per investigation in the issue, the root cause is return statement is missing in the painless script generated. Please the comment on the code changes for more details.
TO-DO: Other built-in functions also have this issue if we disable semantic analyzer (which disallow this) and do "SUM(ABS(a))". I tried a quick fix but it broke existing ITs. Here we only fix aggregate function on
CASTstatement. The issue should go away once new query engine enabled.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.