This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Integ migration #77
Merged
Integ migration #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsen-es
reviewed
Jun 7, 2019
| catch (SqlParseException | SQLFeatureNotSupportedException e) { | ||
| throw new IllegalStateException("Query failed: " + sql, e); | ||
| } | ||
| private SearchResponse execute(String sql) throws IOException { |
There was a problem hiding this comment.
np: this function is now in too many places, would be good to re-use. You can add a TODO for now at least to have some way of tracking.
There was a problem hiding this comment.
Sure, will add a comment for TODO.
arsen-es
approved these changes
Jun 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #76 , if available:
Description of changes:
Migrate NestedFieldQuery, QueryFunctions, SourceField from maven to gradle.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.