This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
DATE_FORMAT function #764
Merged
DATE_FORMAT function #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch#522) * Bug fix, support long type for aggregation * change to datetime to JDBC format
* prepare odfe 1.9 * Fix all ES 7.8 compile and build errors * Revert changes as Lombok is working now * Update CustomExternalTestCluster.java * Fix license headers check * Use splitFieldsByMetadata to separate fields when calling SearchHit constructor * More fixes for ODFE 1.9 * Remove todo statement * Add ODFE 1.9.0 release notes
…ticsearch#551) * Revert "Rename release notes to use 4 digit versions (opendistro-for-elasticsearch#547)" This reverts commit 33c6d3e. * Revert "Opendistro Release 1.9.0 (opendistro-for-elasticsearch#532)" This reverts commit 254f2e0. * Revert "Bug fix, support long type for aggregation (opendistro-for-elasticsearch#522)" This reverts commit fb2ed91.
Merge develop to master
…h#549) (opendistro-for-elasticsearch#554) * merge all sql repos * fix test and build workflows * fix workbench and odbc path * fix workbench and odbc path * restructure workbench dir and fix workflows * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * revert workbench directory structure * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * update workbench workflow for release * Delete .github/ in sql-workbench directory * Add cypress to sql-workbench * Sync latest ODBC commits * Sync latest workbench commits (will add cypress in separate PR) * Add ignored ODBC libs
* add date and time support * update doc * update doc
…ticsearch#633) Merge develop to master for ODFE 1.9.0.1 release
…stro-for-elasticsearch#638) Merge fixes for github release actions from develop to master
…rch#642) Fix odbc win32 release workflow for master
…-elasticsearch#645) - add null check to avoid crashing if details not initialized
…or-elasticsearch/develop Merge develop branch into master to cut odfe1.10 release
…lasticsearch#701) Merge develop branch into master for od1.10 release
…icsearch#704） Merge workflow fix to master for od1.10 release
…sticsearch#733) Merge develop to master for ODFE 1.10.1.0 release
…arch/sql into lyndon/date-format-function
…/sql into lyndon/date-format-function
…ime-function-week # Conflicts: # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprStringValue.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/DSL.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/datetime/DateTimeFunction.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/function/BuiltinFunctionName.java # docs/user/dql/functions.rst # integ-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/ppl/DateTimeFunctionIT.java # ppl/src/main/antlr/OpenDistroPPLParser.g4 # sql/src/main/antlr/OpenDistroSQLParser.g4
…into lyndon/date-format-function\
…arch/sql into lyndon/date-format-function [1] Fixing merge conflicts
rupal-bq
approved these changes
Oct 1, 2020
penghuo
reviewed
Oct 1, 2020
| * @param formatExpr the format ExprValue of String type. | ||
| * @return Date formatted using format and returned as a String. | ||
| */ | ||
| static ExprValue getFormattedDate(ExprValue dateExpr, ExprValue formatExpr) { |
There was a problem hiding this comment.
Not sure the use case. Do you try to do something like this format.replace("%\W", () -> replace).
If so, i recommended to consider the https://docs.oracle.com/javase/7/docs/api/java/util/regex/Matcher.html#appendReplacement(java.lang.StringBuffer,%20java.lang.String)
which provide the more clean code structure.
There was a problem hiding this comment.
I didn't realize I could do this, tahnks for the suggestion! I have updated with this change.
penghuo
reviewed
Oct 1, 2020
| * @param format Incoming format String without mapping completed. | ||
| * @return Outgoing format String with mapping completed. | ||
| */ | ||
| private static String literalReplace(String format) { |
There was a problem hiding this comment.
What is the expected result if the user input the format string which we doesn't support?
There was a problem hiding this comment.
Do you mean a format we don't support, such as %z?
According to the documentation for MySQL it should come out as just z, so using the DateTimeFormatter specification, to get a literal out, we wrap in ', so %z => 'z'.
There was a problem hiding this comment.
Got it, does it covered in the test cases also?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #710
Description of changes:
Added implementation, unit tests, manual integration tests, and documentation for date_format function.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.