This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support date and time function: week #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 18, 2020 17:26
…ime-function-week # Conflicts: # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/DSL.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/datetime/DateTimeFunction.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/function/BuiltinFunctionName.java # core/src/test/java/com/amazon/opendistroforelasticsearch/sql/expression/datetime/DateTimeFunctionTest.java
…ime-function-week
lyndonbauto
reviewed
Sep 25, 2020
integ-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/ppl/DateTimeFunctionIT.java
Outdated
Show resolved
Hide resolved
lyndonbauto
reviewed
Sep 25, 2020
integ-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/DateTimeFunctionIT.java
Outdated
Show resolved
Hide resolved
lyndonbauto
approved these changes
Sep 25, 2020
added 2 commits
September 25, 2020 13:25
lyndonbauto
reviewed
Sep 28, 2020
.../main/java/com/amazon/opendistroforelasticsearch/sql/expression/datetime/CalenderLookup.java
Outdated
Show resolved
Hide resolved
added 2 commits
September 28, 2020 09:58
…ime-function-week # Conflicts: # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprStringValue.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/DSL.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/datetime/DateTimeFunction.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/function/BuiltinFunctionName.java # docs/user/dql/functions.rst # integ-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/ppl/DateTimeFunctionIT.java # ppl/src/main/antlr/OpenDistroPPLParser.g4 # sql/src/main/antlr/OpenDistroSQLParser.g4
chloe-zh
reviewed
Sep 29, 2020
...java/com/amazon/opendistroforelasticsearch/sql/expression/datetime/DateTimeFunctionTest.java
Show resolved
Hide resolved
added 2 commits
September 29, 2020 13:19
chloe-zh
approved these changes
Sep 30, 2020
penghuo
reviewed
Sep 30, 2020
| * Returns week number for date according to mode. | ||
| * @param mode Integer for mode. Valid mode values are 0 to 7. | ||
| */ | ||
| public int getWeekNumber(int mode) { |
There was a problem hiding this comment.
could this function be static to avoid consturct CalendarLookup every time?
e.g. getWeekNumber(ExprValue date, ExprValue mode)
then define getCalendar(int firstDayOfWeek, int minimalDaysInWeek, Supplier dateProvider)
There was a problem hiding this comment.
Thanks for the suggestion. added this change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #709
Description of changes:
Added implementation, unit test, manual IT, and doc updates for function week()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.