This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support select fields and alias in new query engine #636
Merged
dai-chen
merged 31 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-select-specific-fields-merge
Jul 31, 2020
Merged
Support select fields and alias in new query engine #636
dai-chen
merged 31 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-select-specific-fields-merge
Jul 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
chloe-zh
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Alias
(unresolved) andNamedExpression
correspondent is added: Both wrap an ordinary expression with original text in query and its alias preserved."30"
is returned in response DSL rather than30
. Now when bulk request generated, test data mapping is used to remove double quotes for certain data types.TODO items:
SELECT index.field, index_alias.field, object/nested.inner_field, text.keyword
. In this case, syntax exception is thrown inExpressionAnalyzer
to fall back to old engine. => Will send a separate PR for index alias support.SELECT object, nested_field
is not supported, in this case syntax exception is thrown in ExpressionAnalyzer too.QueryIT.backticksQuotedIndexNameTest
andPrettyFormatResponseIT.fieldsWithAlias
are disabled temporarily, because new engine response is slightly different from the old, ex. noalias
field in schema,string
type is returned instead oftext
etc. => Will enable all after a new JDBC formatter is added to new engine.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.