Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add comparsion operator for SQL #635

Merged

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Jul 29, 2020

Description of changes:*

  1. Add Comparsion operator support for SQL.
    https://github.com/penghuo/sql/blob/pr-operator-enhancement/docs/user/dql/expressions.rst#comparison-operators
  2. Refactor the BinaryPredicateOperator and UnaryPredicateOperator.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo requested review from chloe-zh and dai-chen July 29, 2020 22:02
@penghuo penghuo self-assigned this Jul 29, 2020
@penghuo penghuo added the SQL label Jul 29, 2020
@penghuo penghuo marked this pull request as ready for review July 29, 2020 23:13
Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@penghuo penghuo merged commit ac098c0 into opendistro-for-elasticsearch:develop Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants