Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add Text and Keyword Data Type #620

Merged

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Jul 27, 2020

Description of changes

  1. Add the Text and Keyword Data Type in Elasticsearch Storage Engine.
  2. Redefine ExprValue interface.
    1.add the observer method to retrieve the value.
    2. add the compareTo method.
    3. add the equlas method.
  3. Simplify the equal and notEqual operator definition in the BinaryPredicateOperator.
  4. Add the doc for Data Types. https://github.com/penghuo/sql/blob/text-keyword-data-type/docs/user/general/datatype.rst

To Reviewers

  1. I am planning an follow up PR to redefine all the operators in BinaryPredicateOperator. The formal doc for operator will been added accordingly.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo requested review from chloe-zh and dai-chen July 27, 2020 16:58
@penghuo penghuo self-assigned this Jul 27, 2020
Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this refactoring!

@penghuo penghuo merged commit b258fda into opendistro-for-elasticsearch:develop Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants