This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add ElasticsearchExprValueFactory in StorageEngine #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dai-chen
approved these changes
Jul 23, 2020
...n/opendistroforelasticsearch/sql/elasticsearch/data/value/ElasticsearchExprValueFactory.java
Show resolved
Hide resolved
chloe-zh
approved these changes
Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The ElasticsearchExprValueFactory is used construct ExprValue from Elasticsearch JSON response. Internally, it use index field mapping meta data to deserialized JSON source data.
To Reviewers
The change in the doctest is becase we are using Jackson to parse Json data now, the column order is different.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.