This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Redefine the Expression interface and Type #550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
1.Expression
In current design, the Expression has two observers, valueOf and type.
The Expression is construct during the analyzer stage with the type environment provided by the storage engine. so the type observer should not rely on the type environment during the execution stage.
The interface of Expression should be changed as follows
2.Expression Type (ExprType)
The ExprType define the Type of expression in the QueryEngine. In current design, ExprType is enum which can't been extended.
In this PR, we define the ExprType as the interface and define the ExprCoreType which extends the ExprType.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.