This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Enforce comparison test in new SQL module #536
Merged
dai-chen
merged 13 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:enforce-comparison-test-merged
Jul 1, 2020
Merged
Enforce comparison test in new SQL module #536
dai-chen
merged 13 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:enforce-comparison-test-merged
Jul 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dai-chen
changed the title
Enforce comparison test merged
Enforce comparison test in new SQL module
Jun 30, 2020
chloe-zh
reviewed
Jun 30, 2020
...rc/test/java/com/amazon/opendistroforelasticsearch/sql/correctness/runner/resultset/Row.java
Show resolved
Hide resolved
penghuo
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
chloe-zh
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #535
Description of changes: Last year we developed a test framework which verifies result by comparing with other SQL implementation. It was integrated with Gradle task to automate the testing. However, due to problems in old codebase, it was only used for reporting instead of being mandatory for plugin build. Now as we start shift to new query engine, the success of comparison test results should be enforced. Reference: https://github.com/opendistro-for-elasticsearch/sql/blob/develop/docs/dev/Testing.md.
SQLCorrectnessIT
to read all queries in specific folder.For now test case file is simply a
txt
file organized in folders undersrc/resources/correctness
ininteg-test
module. There are 3 categories:For example, for failed test case, a new
explain
field is added to describe which column type or data row is different.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.