This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Add new sql module #527
Merged
dai-chen
merged 17 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:add-new-sql-module
Jun 26, 2020
Merged
Add new sql module #527
dai-chen
merged 17 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:add-new-sql-module
Jun 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
reviewed
Jun 26, 2020
legacy/src/main/java/com/amazon/opendistroforelasticsearch/sql/legacy/plugin/RestSqlAction.java
Show resolved
Hide resolved
penghuo
reviewed
Jun 26, 2020
core/src/main/java/com/amazon/opendistroforelasticsearch/sql/planner/logical/LogicalValues.java
Outdated
Show resolved
Hide resolved
penghuo
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
chloe-zh
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #264, #256
Description of changes: Add new SQL module to integrate with new query engine. As our start point,
SELECT
literal support is added.Here are the major changes:
sql
Gradle module.SELECT
literal by:2.1 Relaxing existing
Project
operator to acceptExpression
instead ofReferenceExpression
.2.2 Adding a new
Values
operator for literal values which is correspondent with ANSIVALUES
clause. Reference: https://modern-sql.com/feature/values, https://crate.io/docs/crate/reference/en/latest/sql/statements/values.html.The
legacy
module with all old code will co-exist with newsql
module during code migration.At runtime, request will send to new SQL parser first and fall back to old code if not supported yet.
Documentation: https://github.com/dai-chen/sql/blob/add-new-sql-module/docs/user/dql/expressions.rst
Testing: Passed old and new UT, IT and doctest.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.