This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix ANTLR grammar for negative integer and floating point number #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
pushed a commit
to penghuo/sql
that referenced
this pull request
Jun 17, 2020
…ndistro-for-elasticsearch#489) * Change grammar and add UT for negative number test * Add IT for negative number syntax check (cherry picked from commit 68cc694)
penghuo
pushed a commit
that referenced
this pull request
Jun 17, 2020
* Change grammar and add UT for negative number test * Add IT for negative number syntax check (cherry picked from commit 68cc694)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #488
Description of changes: Fixed the wrong ANTLR grammar by removing dash from beginning of
IDliteral. This makes dash only be able to present in the middle of an identifier. So negative number started with dash won't be matched byID.Original MySQL grammar: https://github.com/antlr/grammars-v4/blob/master/sql/mysql/Positive-Technologies/MySqlLexer.g4#L1197
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.