Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[PPL] Add simple json formatter #476

Merged

Conversation

dai-chen
Copy link
Member

Issue #, if available:

Description of changes: Add a new protocol module for query request parsing and response formatting. Note that the reason of not use existing common module is due to dependency cycle between core and common module.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chen dai-chen added the PPL label May 20, 2020
@dai-chen dai-chen self-assigned this May 20, 2020
@dai-chen dai-chen marked this pull request as ready for review May 20, 2020 17:37
Copy link
Contributor

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@dai-chen dai-chen merged commit 5ce4b56 into opendistro-for-elasticsearch:feature/ppl May 20, 2020
@dai-chen dai-chen deleted the add-table-formatter branch May 20, 2020 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants