Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[PPL] Add support for fields command #472

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented May 19, 2020

Issue #, if available:

Description of changes:

PPL

  1. add UT to fields command in AST builder.
  2. change the Fields arguments from UnresolvedExpression to Argument.

Core

  1. add logical and physical operator for project and remove.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo changed the title Add support for fields command [PPL] Add support for fields command May 20, 2020
@penghuo penghuo added the PPL label May 20, 2020
Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good!

@penghuo penghuo merged commit 8e4453f into opendistro-for-elasticsearch:feature/ppl May 20, 2020
@penghuo penghuo deleted the feature/fields-command branch June 19, 2020 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants