Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add where stats rename command #466

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented May 14, 2020

Changes

PPL

  1. Change the stats command antlr.
  2. Add the rename node in AST.

Core

  1. Implement the Aggregator interface. Only avg and sum is add in this PR
  2. Implement the Rename, Filter and Aggregation physical operator.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!


/**
* Todo, testing purpose, delete later.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment?

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor comment. Thanks!

@penghuo penghuo merged commit 30703ea into opendistro-for-elasticsearch:feature/ppl May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants