Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[PPL] Create ANTLR parser and implement basic syntax - Phase0 #429

Merged
merged 26 commits into from
Apr 23, 2020
Merged

[PPL] Create ANTLR parser and implement basic syntax - Phase0 #429

merged 26 commits into from
Apr 23, 2020

Conversation

chloe-zh
Copy link
Member

Issue #, if available:

Description of changes:

  • Implemeted AST builder for commands in phase0, with basic syntax.
  • Added unit tests
  • TODO: investigate the feasibility to implement the rest part of syntax in these commands; enrich the AST draft with complete syntax that P0 should achieve

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

penghuo
penghuo reviewed Apr 14, 2020
View reviewed changes
ppl/build.gradle Outdated Show resolved Hide resolved
dai-chen
dai-chen reviewed Apr 14, 2020
View reviewed changes
Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we can draft a simple design doc with some diagram. Probably draw or generate a class diagram quickly so we can track these new abstractions.

ppl/src/main/antlr/OpenDistroPPLParser.g4 Show resolved Hide resolved
ppl/src/main/java/com/amazon/opendistroforelasticsearch/sql/ppl/node/AbstractNodeVisitor.java Outdated Show resolved Hide resolved
ppl/src/main/java/com/amazon/opendistroforelasticsearch/sql/ppl/parser/AstBuilder.java Outdated Show resolved Hide resolved
...src/main/java/com/amazon/opendistroforelasticsearch/sql/ppl/parser/AstExpressionBuilder.java Outdated Show resolved Hide resolved
...src/main/java/com/amazon/opendistroforelasticsearch/sql/ppl/parser/AstExpressionBuilder.java Show resolved Hide resolved
ppl/src/main/java/com/amazon/opendistroforelasticsearch/sql/ppl/plans/expression/And.java Outdated Show resolved Hide resolved
...n/java/com/amazon/opendistroforelasticsearch/sql/ppl/plans/expression/AggregateFunction.java Outdated Show resolved Hide resolved
ppl/src/main/java/com/amazon/opendistroforelasticsearch/sql/ppl/plans/logical/Aggregation.java Outdated Show resolved Hide resolved
ppl/src/main/java/com/amazon/opendistroforelasticsearch/sql/ppl/plans/logical/HasInput.java Outdated Show resolved Hide resolved
penghuo
penghuo reviewed Apr 23, 2020
View reviewed changes
ppl/src/main/java/com/amazon/opendistroforelasticsearch/sql/ppl/plans/logical/Aggregation.java
@ToString
@EqualsAndHashCode(callSuper = false)
@AllArgsConstructor
public class Aggregation extends UnresolvedPlan {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lombok has Buiilder annotation, could you use it?

dai-chen
dai-chen approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

penghuo
penghuo approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@chloe-zh chloe-zh merged commit ded0421 into opendistro-for-elasticsearch:feature/ppl Apr 23, 2020
@chloe-zh chloe-zh mentioned this pull request Apr 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhongnansu zhongnansu zhongnansu left review comments

@dai-chen dai-chen dai-chen approved these changes

@penghuo penghuo penghuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chloe-zh @penghuo @zhongnansu @dai-chen