This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[PPL] init basic codebase structure #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
approved these changes
Apr 6, 2020
Comment on lines
-19
to
+18
| // When upgrading to version after 7.3.0, must remove also | ||
| // project substitution from configurations.all (line 39) | ||
| es_version = System.getProperty("es.version", "7.6.1") | ||
| es_version = "7.6.1" |
There was a problem hiding this comment.
Nothing about this PR, but I wonder if another PR is needed to remove these deprecated in master as well. I can run some tests and help with that.
chloe-zh
approved these changes
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #257
Purpose of the PR
1.PoC the idea proposed in #257.
2.Unblock the development of PPL and SQL migration.
Description of changes
1.1.plugin, Implement the Elasticsearch required Plugin framework.
1.2.ppl, Implement the PPL specific logic.
1.3.integ-test, integration test.
Notes
1.The source code is purely used to PoC. it will be changed later.
2.The build.gradle is not optimized. Pending on the move sql to sub-module.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.