This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Add the expression support post processing #352
Merged
penghuo
merged 12 commits into
opendistro-for-elasticsearch:master
from
penghuo:expression-support
Jan 24, 2020
Merged
Add the expression support post processing #352
penghuo
merged 12 commits into
opendistro-for-elasticsearch:master
from
penghuo:expression-support
Jan 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just 1 minor question
} | ||
|
||
@Test | ||
public void absWithStringShouldThrowException() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason only ABS() and Tan2() were tested against with String values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally all the type should been tested. the purpose of the test is to verify the error message is as expected.
dai-chen
approved these changes
Jan 24, 2020
chloe-zh
approved these changes
Jan 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#229
#194
#270
#292
Description of changes:
1.Data Models
The following paragraph describe the BNF grammar for Expression Values.
The type of the values are: collection_value, tuple_value, missing_value, scalar_value.
2.BindingTuple
BindingTuple is a set of <bindingName, value>. e.g. Taken the following sample JSON object as example, There are two <bindingName, value> pairs in the BindingTuple. (1) <“integerValue”, integer_value(1)>, (2) <“stringValue”, “string”>.
3.Expression
The following paragraph describe the behavior of the Expression.
Let’s take an example to explain how to construct the expression and evaluate the expression in the BindingTuple context.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.